this post was submitted on 17 Sep 2025
199 points (99.0% liked)
Programming
22764 readers
89 users here now
Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!
Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.
Hope you enjoy the instance!
Rules
Rules
- Follow the programming.dev instance rules
- Keep content related to programming in some way
- If you're posting long videos try to add in some form of tldr for those who don't want to watch videos
Wormhole
Follow the wormhole through a path of communities !webdev@programming.dev
founded 2 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
I don't get the first part on pull requests, you can't just say:
and then also say:
You have to make a valid proposal to say how the workflow could be "improved" (if it really can be), otherwise we're talking about nothingness, the draft that is written in the middle is very vague IMO, what I'm really missing is what are the specific problems in the PR process, you say:
It's true and I don't see how things can work otherwise, the point made in the linked article (emphasis mine):
Confidence is completely subjective, some small change that you are confident will touch that place and only that, might well affect other parts of the code that you don't know about, and who knows about it? The people that have worked on that code. I've worked a lot on a codebase where the main developer stepped down from his role to do managerial tasks and he doesn't perform any code review at all mainly because the company doesn't value the review process, so there's no time for it, but also, even if there was, he can't remember anything he's written.
So it's not rare that I touch some code, approve it myself and a user notices that something broke once it has hit production, I was confident in the change I made and I was wrong, I couldn't have known that because I didn't have the full knowledge of the codebase.
When I'm not confident, I usually ask and get a little feedback, it usually helps, but it's not exhaustive, so some issues might crop up anyways, even still, I might be working on something I created and be confident, but my mind was hazy at the time of making the changes, so I make mistakes anyway.
That's why I believe that a strict review process is always beneficial, even for supposed "stupid" changes, because you're not editing a document, you're editing code that will run, a mistake somewhere has effects elsewhere and wrong code has no place hitting production if it can reasonably be prevented, those "small hotfixes" that are urgently needed to fix that broken thing in production will often lead to some other issue somewhere because you were pressured to think fast and get out a dirty solution which will likely cause some problem you hadn't foreseen in your supposed confidence further down the line.
What do we have on the other side, collaborative editing? A live feed of what the others are doing so anyone in the team can step in to help? That's spreading the attention of the experienced developers that I imagine would be involved in this collaboration too thin, they would have to waste time thinking what the mental process of the other developer is, even in an interrupted stage, where everything is up in the air, that is huge cognitive load, it makes way more sense to put that load on the single developer that has to refine their work until it's presentable, then, if they run into some problem midway, they will usually ask questions on logic and architecture, more so than code, and even if it is about code, their current codebase state can be pulled from their repository object of the PR to try out