Please for the love of god don't use merge, especially in a crowded repository. Don't be me and suffer the consequences. I mistakenly mention every person with a commit between the time I created the branch until current master.

[–] nialv7@lemmy.world 19 points 7 months ago (1 children)

That was you! I remember this.

[–] tengkuizdihar@programming.dev 22 points 7 months ago (1 children)

AAAH NOT LIKE THIS

[–] bear@slrpnk.net 31 points 7 months ago

There's 102 people mentioned in that commit and two of them happen to meet in the comments of a meme thread on Lemmy of all places. I love the Internet.

[–] jaemo@sh.itjust.works 10 points 7 months ago

Could have been worse. I mean, like, imagine of you were using like CVS and you put a watch on the root! Haha and then like every trivial commit in the repo caused everyone to in the entire org to get an email and it crashed the email servers.

Like who'd even DO that?! Though, I bet if you met that guy he'd be ok. Like not a jerk, and pretty sorry for all those emails. A cool guy.

[–] Atemu@lemmy.ml 5 points 7 months ago (1 children)

Merge is not the issue here, rebase would do the same.

[–] tengkuizdihar@programming.dev 3 points 7 months ago (1 children)

really? how come? I thought they are mentioned because of the diffs if compared to master, which merge basically just... merge on top of my branch (?)

[–] Atemu@lemmy.ml 2 points 7 months ago (1 children)

They were mentioned because a file they are the code owner of was modified in the PR.

The modifications came from another branch which you accidentally(?) merged into yours. The problem is that those commits weren't in master yet, so GH considers them to be part of the changeset of your branch. If they were in master already, GH would only consider the merge commit itself part of the change set and it does not contain any changes itself (unless you resolved a conflict).

If you had rebased atop of the other branch, you would have still had the commits of the other branch in your changeset; it'd be as if you tried to merge the other branch into master + your changes.

[–] Bourff@lemmy.world -1 points 7 months ago* (last edited 7 months ago) (1 children)

Just for the record, I think you're conflating git and GitHub. They are not the same thing, even if GH would like you to think so.

[–] Atemu@lemmy.ml 2 points 7 months ago

I am not. Read the context mate.

[–] droans@lemmy.world 2 points 7 months ago

You sent over twenty-two thousand notifications lmao.

And then the bot added about as many tags to the PR.