this post was submitted on 29 Mar 2024
970 points (98.3% liked)

Programmer Humor

19623 readers
1 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS
Feyter@programming.dev
anzo@programming.dev
BurningTurtle@programming.dev
pylapp@programming.dev
970
Review Please (programming.dev)
submitted 8 months ago by JPDev@programming.dev to c/programmer_humor@programming.dev
105 comments fedilink hide all child comments
 
you are viewing a single comment's thread
view the rest of the comments
[–] nick@campfyre.nickwebster.dev 3 points 8 months ago (1 children)

In my experience I haven't had an issue because usually the refactorings are small. If they're not I just hop on a call with the person who wrote the MR and ask them to walk me through it.

In theory I'd like to have time to dedicate solely to code health, but that's not quite the situation in basically any team I've been in.

[–] onlinepersona@programming.dev 1 points 8 months ago

I haven't had any trouble separating refactors PRs from ticket PRs. Make the ticket PR, make a refactor PR on that ticket PR, merge the ticket PR, rebase refactor PR on master, open ticket PR for review, done 🤷

CC BY-NC-SA 4.0